ajweave commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1644818928
##########
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##########
@@ -46,28 +47,46 @@ default void onSuccess(
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node) {}
+ /**
+ * @deprecated This method only exists for backward compatibility. Override
{@link
+ * #onSuccess(Request, long, DriverExecutionProfile, Node,
ExecutionInfo, String)} instead.
+ */
+ @Deprecated
+ default void onSuccess(
+ @NonNull Request request,
+ long latencyNanos,
+ @NonNull DriverExecutionProfile executionProfile,
+ @NonNull Node node,
+ @NonNull String requestLogPrefix) {
+ // If client doesn't override onSuccess with requestLogPrefix delegate
call to the old method
+ onSuccess(request, latencyNanos, executionProfile, node);
+ }
+
/**
* Invoked each time a request succeeds.
*
* @param latencyNanos the overall execution time (from the {@link
Session#execute(Request,
* GenericType) session.execute} call until the result is made available
to the client).
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
+ * @param executionInfo the execution info containing the results of this
request
* @param requestLogPrefix the dedicated log prefix for this request
*/
default void onSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
+ @NonNull ExecutionInfo executionInfo,
@NonNull String requestLogPrefix) {
- // If client doesn't override onSuccess with requestLogPrefix delegate
call to the old method
- onSuccess(request, latencyNanos, executionProfile, node);
+ // If client doesn't override onSuccess with executionInfo delegate call
to the old method
Review Comment:
Good point. As long as we retain and deprecate the old method signatures
for backwards-compatability, I'm good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
