chibenwa commented on code in PR #1623:
URL:
https://github.com/apache/cassandra-java-driver/pull/1623#discussion_r1644181496
##########
core/src/main/java/com/datastax/oss/driver/internal/core/cql/Conversions.java:
##########
@@ -543,21 +543,44 @@ public static boolean resolveIdempotence(Request request,
InternalDriverContext
: requestIsIdempotent;
}
+ public static boolean resolveIdempotence(Request request,
DriverExecutionProfile executionProfile) {
+ Boolean requestIsIdempotent = request.isIdempotent();
+ return (requestIsIdempotent == null)
+ ?
executionProfile.getBoolean(DefaultDriverOption.REQUEST_DEFAULT_IDEMPOTENCE)
+ : requestIsIdempotent;
+ }
+
Review Comment:
Ok I proposed two fixups for implementing those suggested changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
