[ 
https://issues.apache.org/jira/browse/CASSANDRA-19697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855094#comment-17855094
 ] 

Stefan Miklosovic commented on CASSANDRA-19697:
-----------------------------------------------

Very interesting investigation.

I wonder what is the side effect of us putting there true as you suggested. It 
ultimately boils down to

{code}
    private void close(boolean force)
    {
        if (!force)
        {
            while (!dispatcher.isDone())
                LockSupport.parkNanos(TimeUnit.MILLISECONDS.toNanos(100));
        }

        // Close opened connections
        connectionTracker.closeAll();

        logger.info("Stop listening for CQL clients");
    }
{code}

So, we are not waiting until dispatcher is done, we just straight close it all 
... Is this safe to do? 

> Test failure: 
> materialized_views_test.py::TestMaterializedViews::test_rename_column_atomicity
> ---------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-19697
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19697
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/Materialized Views
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 5.0-rc, 5.x
>
>         Attachments: shutdown_stuck.txt
>
>
> Breaking this out from CASSANDRA-19683.  The byteman script fails to execute 
> in 5.0/trunk after CASSANDRA-19534.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to