[
https://issues.apache.org/jira/browse/CASSANDRA-19583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854780#comment-17854780
]
Brandon Williams commented on CASSANDRA-19583:
----------------------------------------------
Looks good to me, let's check CI:
||Branch||CI||
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-19583-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1671/workflows/2d7cad88-d891-4337-b984-abbcac38ed20],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1671/workflows/980121dd-ac7f-4747-91fa-391d961c9c5b]|
|[5.0|https://github.com/driftx/cassandra/tree/CASSANDRA-19583-5.0]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1672/workflows/efe20fe2-b4b4-45c5-badc-759bcbd42423],
[j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1672/workflows/ae2b4dd7-ef7f-4f70-ae7e-325a1cc91ec0]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-19583-trunk]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1670/workflows/410aea7f-0b3a-438d-8d1e-dcfc2a75f837],
[j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1670/workflows/93bb8e03-692f-41f1-8dcd-dcfd84e9ca4b]|
> Make 0 work as 0+unit for all three config classes (DataStorageSpec,
> DurationSpec, DataRateSpec)
> ------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-19583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19583
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Jon Haddad
> Assignee: Arun Ganesh
> Priority: Normal
> Fix For: 4.1.x, 5.0.x, 5.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The inline docs say:
> {noformat}
> Setting this to 0 disables throttling.
> {noformat}
> However, on startup, we throw this error:
> {noformat}
> Caused by: java.lang.IllegalArgumentException: Invalid data rate: 0 Accepted
> units: MiB/s, KiB/s, B/s where case matters and only non-negative values a>
> Apr 23 23:12:01 cassandra0 cassandra[3424]: at
> org.apache.cassandra.config.DataRateSpec.<init>(DataRateSpec.java:52)
> Apr 23 23:12:01 cassandra0 cassandra[3424]: at
> org.apache.cassandra.config.DataRateSpec.<init>(DataRateSpec.java:61)
> Apr 23 23:12:01 cassandra0 cassandra[3424]: at
> org.apache.cassandra.config.DataRateSpec$LongBytesPerSecondBound.<init>(DataRateSpec.java:232)
> Apr 23 23:12:01 cassandra0 cassandra[3424]: ... 27 common frames
> omitted
> {noformat}
> We should allow 0 without a unit attached for data, duration, and data spec
> config parameters, as 0 is always 0 no matter the unit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
