[
https://issues.apache.org/jira/browse/CASSANDRA-19679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852445#comment-17852445
]
Benjamin Lerer commented on CASSANDRA-19679:
--------------------------------------------
{quote}It turns out SimpleRestriction is new and exists in trunk only. The same
code snippet is not present in 5.0 anywhere, so does not need porting to
5.0.{quote}
It is one of the latest refactoring I did. I underestimated that one. Should
have listen to [~Bereng] review feedback.
{quote}Out of interest, I will profile 5.0 later today as I see other stream
usage.{quote}
[~samueldlightfoot] Just a suggestion: for the CQL layer, it might be easier to
look at where the Streams are located within the code and build queries that
can hit them. Considering how many possible queries exist it is easy to miss
some part of the code.
> Stream processing for SimpleRestriction::bindAndGetClusteringElements
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-19679
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19679
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
> Reporter: Sam Lightfoot
> Assignee: Sam Lightfoot
> Priority: Normal
> Fix For: 5.x
>
> Attachments: after.png, alloc_after.html, alloc_before.html,
> image-2024-06-04-21-55-34-457.png
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Part 2 (of 2) of low-hanging fruit Stream performance improvements.
> The second main Stream contributor to allocations and CPU was
> SimpleRestriction::bindAndGetClusteringElements, which contributes to 5% of
> all allocations for a 50/50 workload. The image attached shows allocation
> profiling on _trunk_ (see purple highlighted sections for Stream-related
> allocs).
> The 'after' profile for a 50/50 workload shows a reduction from 4.58%
> allocations down to 1.69%. For a 90/10 (w/r) workload we see 4.28% decrease
> to 1.10%.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
