arjunashok commented on code in PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#discussion_r1420983422
########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkSourceRelation.java: ########## @@ -98,39 +95,19 @@ public void insert(@NotNull Dataset<Row> data, boolean overwrite) Tokenizer tokenizer = new Tokenizer(writerContext); TableSchema tableSchema = writerContext.schema().getTableSchema(); JavaPairRDD<DecoratedKey, Object[]> sortedRDD = data.toJavaRDD() - .map(Row::toSeq) - .map(seq -> JavaConverters.seqAsJavaListConverter(seq).asJava().toArray()) - .map(tableSchema::normalize) - .keyBy(tokenizer::getDecoratedKey) - .repartitionAndSortWithinPartitions(broadcastContext.getValue().job().getTokenPartitioner()); + .map(Row::toSeq) + .map(seq -> JavaConverters.seqAsJavaListConverter(seq).asJava().toArray()) + .map(tableSchema::normalize) + .keyBy(tokenizer::getDecoratedKey) + .repartitionAndSortWithinPartitions(broadcastContext.getValue().job().getTokenPartitioner()); Review Comment: Agreed, this is out of scope from this PR. I believe this was applied by the code-style plugin. Will leave it as-is for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org