[
https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790733#comment-17790733
]
Stefan Miklosovic edited comment on CASSANDRA-18935 at 11/28/23 7:45 PM:
-------------------------------------------------------------------------
Good news is that I have a non-flaky test in CASSANDRA-19103 implemented for
coordinator + storage nodes scenario. Maybe we could rewrite what is in dtest
to in-jvm dtest when it comes to test_counter_leader_with_partial_view . I
started the multiplexer on current 5.0 to see if it is flaky already or I made
it like that.
was (Author: smiklosovic):
Good news is that I have a non-flaky test in CASSANDRA-19103 implemented. Maybe
we could rewrite what is in dtest to in-jvm dtest when it comes to
test_counter_leader_with_partial_view . I started the multiplexer on current
5.0 to see if it is flaky already or I made it like that.
> Fix nodetool enable/disablebinary to correctly set rpc
> ------------------------------------------------------
>
> Key: CASSANDRA-18935
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18935
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Core, Legacy/CQL
> Reporter: Cameron Zemek
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Attachments: 18935-3.11.patch, image-2023-11-16-10-56-16-693.png,
> signature.asc
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
>
> {code:java}
> if ((nativeFlag != null && Boolean.parseBoolean(nativeFlag)) ||
> (nativeFlag == null && DatabaseDescriptor.startNativeTransport()))
> {
> startNativeTransport();
> StorageService.instance.setRpcReady(true);
> } {code}
> The startup code here only sets RpcReady if native transport is enabled. If
> you call
> {code:java}
> nodetool enablebinary{code}
> then this flag doesn't get set.
> But with the change from CASSANDRA-13043 it requires RpcReady set to true in
> order to get a leader for the counter update.
> Not sure what the correct fix is here, seems to only really use this flag for
> counters. So thinking perhaps the fix is to just move this outside the if
> condition.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
