[
https://issues.apache.org/jira/browse/CASSANDRA-18366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761408#comment-17761408
]
dan jatnieks commented on CASSANDRA-18366:
------------------------------------------
{quote}the 4.1 version of FailingRepairTest, I see a similar change there:
[https://github.com/apache/cassandra/blob/20125c5053586ab46fa341ac71cc525b64932873/test/distributed/org/apache/cassandra/distributed/test/FailingRepairTest.java#L169-L172]
Maybe it's better to port that change back to 4.0 to keep things consistent?
{quote}
Well, just porting that one change to {{FailingRepairTest}} isn't going to
work. It was part of CASSANDRA-17116 which also added code to have the
{{InstanceKiller}} shutdown the instance when {{killCurrentJVM}} is called.
[https://github.com/apache/cassandra/blob/20125c5053586ab46fa341ac71cc525b64932873/test/distributed/org/apache/cassandra/distributed/impl/Instance.java#L683]
Since that's not in 4.0, the instance is not shutdown, and porting just that
change to {{FailingRepairTest}} from 4.1 doesn't fix the test.
So, unless we want to port all of CASSANDRA-17116 back to 4.0, the original
change I proposed that just re-starts gossip should be okay for 4.0.
> Test failure: org.apache.cassandra.distributed.test.FailingRepairTest -
> testFailingMessage[VALIDATION_REQ/parallel/true]
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18366
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18366
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
> Reporter: Brandon Williams
> Assignee: dan jatnieks
> Priority: Normal
> Fix For: 4.0.x
>
>
> First seen
> [here|https://app.circleci.com/pipelines/github/driftx/cassandra/928/workflows/f4e93a72-d4aa-47a2-996f-aa3fb018d848/jobs/16206]
> this test times out for me consistently on both j8 and j11 where 4.1 and
> trunk do not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
