jberragan commented on code in PR #11:
URL:
https://github.com/apache/cassandra-analytics/pull/11#discussion_r1294923879
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/sparksql/SparkCellIterator.java:
##########
@@ -339,21 +337,28 @@ private void maybeRebuildPartition()
}
// Or new partition, so deserialize partition keys and update 'values'
array
- ByteBuffer partitionKey = rid.getPartitionKey();
- if (numPartitionKeys == 1)
+ readPartitionKey(rid.getPartitionKey(), cqlTable, this.values, stats);
+ }
+
+ public static void readPartitionKey(final ByteBuffer partitionKey,
+ final CqlTable table,
+ final Object[] values,
+ final Stats stats)
+ {
+ if (table.numPartitionKeys() == 1)
{
// Not a composite partition key
- CqlField field = cqlTable.partitionKeys().get(0);
- values[field.position()] = deserialize(field, partitionKey);
+ final CqlField field = table.partitionKeys().get(0);
Review Comment:
I don't see this check style in
https://github.com/apache/cassandra-analytics/blob/trunk/config/checkstyle/checkstyle.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
