[
https://issues.apache.org/jira/browse/CASSANDRA-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750037#comment-17750037
]
Ekaterina Dimitrova edited comment on CASSANDRA-17161 at 8/1/23 11:17 PM:
--------------------------------------------------------------------------
{quote}This property was deprecated in 4.0 afaik. So by the rule of "wait one
major and remove", this is eligible for deletion 5.0.
{quote}
True but there were still some discussions that we might want to leave the
properties in Config with @Deprecated so we don't break people.
{quote}An upgrade from 4.1 having a yaml containing that property will fail
with the current patch. This could be understood as breaking backward
compatibility. I guess the alternative approach would be keeping the old
property ad aeternum and logging a warning saying that the property is going to
be ignored. I don't know if we have already had that discussion on the dev list
and I have missed it but, if not, we should probably have it now
{quote}
I agree that I also don't recall the final agreement here and it's probably
worth it to bring it to the ML to be confirmed once and for all.
was (Author: e.dimitrova):
{quote}This property was deprecated in 4.0 afaik. So by the rule of "wait one
major and remove", this is eligible for deletion 5.0.
{quote}
True but there were still some discussions that we might want to leave the
propertyies in Config with @Deprecated.
{quote}An upgrade from 4.1 having a yaml containing that property will fail
with the current patch. This could be understood as breaking backward
compatibility. I guess the alternative approach would be keeping the old
property ad aeternum and logging a warning saying that the property is going to
be ignored. I don't know if we have already had that discussion on the dev list
and I have missed it but, if not, we should probably have it now
{quote}
I agree that I also don't recall final agreement here and it's probably worth
it to bring it to the ML to be confirmed once and for all.
> Remove commitlog_sync_batch_window_in_ms
> ----------------------------------------
>
> Key: CASSANDRA-17161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17161
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> commitlog_sync_batch_window_in_ms is deprecated in 4.0 and has to be removed
> in 5.0
> This will require also some work around the in-jvm upgrade tests.
> Currently they do not work if we remove a parameter in a later version.
> Side note: They also don't work if we change the type of the parameter in
> Config class in a newer Cassandra version. If you plan to set it in the tests
> themselves, it won't work. If you change the type but your don't set the
> parameter, no issue so there might be some workaround solution instead of
> working on the dtest framework itself.... TBD
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
