[ 
https://issues.apache.org/jira/browse/CASSANDRA-18314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748617#comment-17748617
 ] 

Michael Semb Wever edited comment on CASSANDRA-18314 at 7/28/23 2:04 PM:
-------------------------------------------------------------------------

CI results look good:
 - 
https://app.circleci.com/pipelines/github/michaelsembwever/cassandra?branch=mck%2F18314%2Ftrunk

 - Handshake.testOutboundConnectionfFallbackDuringUpgrades was discovered as an 
[existing|https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/217/workflows/ce7392fa-756a-4392-b3a5-206bb2940553/jobs/15965/tests]
 flakey
 - STablesSystemViewTest#testVirtualTableThroughIndexLifeCycle is in trunk, 
[ticket created|https://issues.apache.org/jira/browse/CASSANDRA-18703]
 - similar 
SSTablesSystemViewTest failures were from the SAI merge and fixed 
[here|https://github.com/apache/cassandra/commit/3ba4cd24a0c6b5a90ac0ed57ec2eec152308f211].
 - SSL broken tests are from jdk17 needing the netty upgrade: CASSANDRA-17992
 - upgrade timestamp tests are from the deletion serialisation merge, see this 
comment in 
[CASSANDRA-18676|https://issues.apache.org/jira/browse/CASSANDRA-18676?focusedCommentId=17747860&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17747860].

for reference, the PR was here: https://github.com/apache/cassandra/pull/2506


was (Author: michaelsembwever):
CI results look good:
 - 
https://app.circleci.com/pipelines/github/michaelsembwever/cassandra?branch=mck%2F18314%2Ftrunk

 - Handshake.testOutboundConnectionfFallbackDuringUpgrades was discovered as an 
[existing|https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/217/workflows/ce7392fa-756a-4392-b3a5-206bb2940553/jobs/15965/tests]
 flakey
 - STablesSystemViewTest#testVirtualTableThroughIndexLifeCycle is in trunk, 
[ticket created|https://issues.apache.org/jira/browse/CASSANDRA-18703]
 - similar 
SSTablesSystemViewTest failures were from the SAI merge and fixed 
[here|https://github.com/apache/cassandra/commit/3ba4cd24a0c6b5a90ac0ed57ec2eec152308f211].
 - SSL broken tests are from jdk17 needing the netty upgrade: CASSANDRA-17992
 - upgrade timestamp tests are from the deletion serialisation merge, see this 
comment in 
[CASSANDRA-18676|https://issues.apache.org/jira/browse/CASSANDRA-18676?focusedCommentId=17747860&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17747860].

> Lift MessagingService.minimum_version to 40
> -------------------------------------------
>
>                 Key: CASSANDRA-18314
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18314
>             Project: Cassandra
>          Issue Type: Task
>          Components: Messaging/Internode
>            Reporter: Michael Semb Wever
>            Assignee: Michael Semb Wever
>            Priority: Normal
>             Fix For: 5.x
>
>          Time Spent: 15h
>  Remaining Estimate: 0h
>
> MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in 
> Cassandra 5.0 anymore.
> (Cassandra 5.0 currently is still using VERSION_40)
> Patch: 
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18314/trunk
> Raises the question whether backward compatibility to the previous major is 
> defined by the Cassandra version or by the internal component version 
> (MessagingService).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to