[
https://issues.apache.org/jira/browse/CASSANDRA-18648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747857#comment-17747857
]
Berenguer Blasi edited comment on CASSANDRA-18648 at 7/27/23 9:19 AM:
----------------------------------------------------------------------
-This seems to have broken a few negative time tests:
https://ci-cassandra.apache.org/job/Cassandra-trunk/1642/#showFailuresLink
investigating-
They pass locally for me. Looking at logs the assertion seems to be coming from
CASSANDRA-18676
Edit: Mystery solved. While the jenkins ran 18676 got committed. So jenkins
pulled in it's upgrade tests the new trunk with 18676
was (Author: bereng):
-This seems to have broken a few negative time tests:
https://ci-cassandra.apache.org/job/Cassandra-trunk/1642/#showFailuresLink
investigating-
They pass locally for me. Looking at logs the assertion seems to be coming from
CASSANDRA-18676
> Improved DeletionTime serialization
> -----------------------------------
>
> Key: CASSANDRA-18648
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18648
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/SSTable
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 5.0
>
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png
>
> Time Spent: 14h 20m
> Remaining Estimate: 0h
>
> DeletionTime.markedForDeleteAt is a long useconds since Unix Epoch. But I
> noticed that with 7 bytes we can already encode ~2284 years. We can either
> shed the 8th byte, for reduced IO and disk, or can encode some sentinel
> values as flags there. [~blerer] suggested starting with DeletionTime.LIVE.
> That would mean reading and writing 1 byte instead of 12 (8 mfda long + 4
> ldts int). Yes we already avoid serializing DeletionTime (DT) in sstables at
> _row_ level entirely but not at _partition_ level and it is also serialized
> at index, metadata, etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
