[ 
https://issues.apache.org/jira/browse/CASSANDRA-18190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718320#comment-17718320
 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-18190 at 5/2/23 10:14 AM:
--------------------------------------------------------------------------

If I use source and target 1.8 to compile with ecj and Java 11, I reduce the 
errors to only 327 (from 57 676). Most of them for: 

 
{code:java}
Potential resource leak: '<unassigned Closeable value>' may not be closed{code}
It seems that the moment we change source and target to 11 that change triggers 
this issue to be caught - in the [Java Platform Module System 
(JPMS)|https://en.wikipedia.org/wiki/Java_Platform_Module_System] it is not 
allowed to use the same package in more than one module. 

Many of the errors I was initially getting were "accessible from more than one 
module" which is enforced by newer Java versions.

 


was (Author: e.dimitrova):
If I use source and target 1.8 to compile with ecj and Java 11, I reduce the 
errors to only 327 (from 57 676). Most of them for: 

 
{code:java}
Potential resource leak: '<unassigned Closeable value>' may not be closed{code}
It seems that the moment we change source and target to 11 owe trigger this - 
in the [Java Platform Module System 
(JPMS)|https://en.wikipedia.org/wiki/Java_Platform_Module_System] it is not 
allowed to use the same package in more than one module. 

Many of the errors I was initially getting were "accessible from more than one 
module" which is enforced by newer Java versions.

 

> ECJ upgrade
> -----------
>
>                 Key: CASSANDRA-18190
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18190
>             Project: Cassandra
>          Issue Type: Task
>          Components: Feature/UDF
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 5.x
>
>
> During testing it was identified that we will need to update ECJ for the Java 
> UDF functions in order to bring Java 17 in.
> It seems the compiler artifacts are moved from 
> [here|https://mvnrepository.com/artifact/org.eclipse.jdt.core.compiler/ecj ] 
> to [here|https://mvnrepository.com/artifact/org.eclipse.jdt/ecj] and there is 
> change of license from EPL1.0 to EPL2.0 too. But if I read correctly 
> [here|https://www.apache.org/legal/resolved.html#weak-copyleft-licenses] that 
> should not affect us
> Further testing and review of all changes between artifacts to be done.
> ECJ is used for the eclipse-warnings and Java UDFs



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to