[
https://issues.apache.org/jira/browse/CASSANDRA-17869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712462#comment-17712462
]
Ekaterina Dimitrova edited comment on CASSANDRA-17869 at 4/14/23 4:41 PM:
--------------------------------------------------------------------------
Thank you for explaining. Now it clicked. It seems in-jvm and python upgrade
paths were in different state in regards to the new major so that confused me.
* When I run(we do this in CircleCI and as far as I recall same in Jenkins):
{{./run_dtests.py --execute-upgrade-tests-only --upgrade-target-version-only
--upgrade-version-selection all --dtest-print-tests-only
--dtest-print-tests-output=/tmp/all_dtest_tests_j8_upgradetests
--cassandra-dir=/cassandra}}
I can see a few upgrade tests from 3.x versions. It seems we need some
additional filtering for those if I am not missing anything.
* cassandra-builds changes will affect also previous branches so I guess when
the time to commit anything comes, we should test them that nothing shifted.
* I also left a few comments in the cassandra-builds commits. I fear there
might be places where we still want to consider CASSANDRA_USE_JDK11 for 4.0 and
4.1 but I guess we should test.
* Also, aren't we going to add upgrade tests with JDK 11 also for 4.0 to 4.1?
It occurs to me that the current patch considers only 4.0 to trunk and 4.1 to
trunk and nothing changes in regards to upgrade tests for 4.0 and 4.1. Those
will continue to be run only with JDK8.
was (Author: e.dimitrova):
Thank you for explaining. Now it clicked. It seems in-jvm and python upgrade
paths were in different state in regards to the new major so that confused me.
* When I run(we do this in CircleCI and as far as I recall same in Jenkins):
{{./run_dtests.py --execute-upgrade-tests-only --upgrade-target-version-only
--upgrade-version-selection all --dtest-print-tests-only
--dtest-print-tests-output=/tmp/all_dtest_tests_j8_upgradetests
--cassandra-dir=/cassandra}}
I can see a few upgrade tests from 3.x versions. It seems we need some
additional filtering for those if I am not missing something.
* cassandra-builds changes will affect also previous branches so I guess when
the time to commit anything comes, we should test them that nothing shifted.
* I also left a few comments in the cassandra-builds commits. I fear there
might be places where we still want to consider CASSANDRA_USE_JDK11 for 4.0 and
4.1 but I guess we should test.
* Also, aren't we going to add upgrade tests with JDK 11 also for 4.0 to 4.1?
It occurs to me that the current patch considers only 4.0 to trunk and 4.1 to
trunk and nothing changes in regards to upgrade tests for 4.0 and 4.1. Those
will continue to be run only with JDK8.
> Add JDK17 option to cassandra-builds (build-scripts and jenkins dsl) and on
> jenkins agents
> ------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17869
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17869
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Add JDK17 option to cassandra-builds build-scripts, they only currently
> support options {{8}} and {{11}}.
> Add JDK17 to the matrix axes in the jenkins dsl.
> Ensure JDK17 is installed on all the jenkins agents.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
