[
https://issues.apache.org/jira/browse/CASSANDRA-16895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704752#comment-17704752
]
Sylwester Lachiewicz edited comment on CASSANDRA-16895 at 3/24/23 6:31 PM:
---------------------------------------------------------------------------
I've tested Cassandra build with Java 20 and found one error that may be worth
to fix here
>From Java 19 we have new method Future.state and it conflicts with our private
>method. Fix bellow.
[https://download.java.net/java/early_access/jdk20/docs/api/java.base/java/util/concurrent/Future.html#state()]
{code}
+++ b/src/java/org/apache/cassandra/utils/concurrent/AbstractFuture.java
@@ -494,11 +494,11 @@ public abstract class AbstractFuture<V> implements
Future<V>
public String toString()
{
String description = description();
- String state = state();
+ String state = stateInfo();
return description == null ? state : (state + ' ' + description);
}
- private String state()
+ private String stateInfo()
{
Object result = this.result;
if (isSuccess(result))
{code}
was (Author: slachiewicz):
I've tested Cassandra build with Java 20 and found one error that may be worth
to fix here
>From Java 19 we have new method Future.state and it conflicts with our private
>method. Fix bellow.
[https://download.java.net/java/early_access/jdk20/docs/api/java.base/java/util/concurrent/Future.html#state()]
+++ b/src/java/org/apache/cassandra/utils/concurrent/AbstractFuture.java
@@ -494,11 +494,11 @@ public abstract class AbstractFuture<V> implements
Future<V>
public String toString()
{
String description = description();
- String state = state();
+ String state = stateInfo();
return description == null ? state : (state + ' ' + description);
}
- private String state()
+ private String stateInfo()
{
Object result = this.result;
if (isSuccess(result))
> Build with Java 17
> ------------------
>
> Key: CASSANDRA-16895
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16895
> Project: Cassandra
> Issue Type: Epic
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
>
> This ticket is intended to group all issues found to support Java 17 in the
> future.
> Upgrade steps:
> * [Dependencies
> |https://mvnrepository.com/artifact/org.apache.cassandra/cassandra-all/4.0.1]to
> be updated (not all but at least those that require an update in order to
> work with Java 17)
> * More encapsulated JDK internal APIs. Some of the issues might be solved
> with the dependencies updates
> * Currently trunk compiles if we remove the Nashorn dependency (ant script
> tag, used for the test environment; UDFs) . The oracle recommendation to use
> Nashorn-core won't work for the project as it is under GPL 2.0. Most probably
> we will opt in for graal-sdk licensed under UPL
> * All tests to be cleaned
> * CI environment to be setup
> *NOTE:* GC tuning, performance testing were never agreed to be part of this
> ticket.
> Below is a snapshot of current CI failures with JDK17, it will be updated on
> a regular basis with a date of update
> *March 19th 2023*
> || ||Failing Test Classes||Ticket Numbers||
> | |_Python DTests_| |
> |1|test_sjk|CASSANDRA-18343|
> | |_Java Ditributed Tests_| |
> |1-6|org.apache.cassandra.distributed.test.ReprepareOldBehaviourTest - all
> tests,
> org.apache.cassandra.distributed.test.PrepareBatchStatementsTest - all tests,
> org.apache.cassandra.distributed.test.IPMembershipTest - both tests,
> org.apache.cassandra.distributed.test.MixedModeFuzzTest,
> org.apache.cassandra.distributed.test.ReprepareFuzzTest,
> org.apache.cassandra.distributed.test.ReprepareNewBehaviourTest|CASSANDRA-16304|
> |7,8|org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
> - all tests
> org.apache.cassandra.distributed.test.InternodeEncryptionOptionsTest - all
> tests|Could be related to CASSANDRA-18180, to be checked |
> |9|org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest -
> 2 tests|CASSANDRA-18180|
> | |_Unit Tests_| |
> |1|org.apache.cassandra.repair.RepairJobTest - 1 test|CASSANDRA-17884|
> |2|org.apache.cassandra.security.SSLFactoryTest - all tests|CASSANDRA-17992|
> |3,4|org.apache.cassandra.db.memtable.MemtableSizeOffheapBuffersTest,
> org.apache.cassandra.utils.concurrent.RefCountedTest|CASSANDRA-18329|
> |5,6|org.apache.cassandra.cql3.validation.entities.UFJavaTest,
> org.apache.cassandra.cql3.validation.entities.UFSecurityTest|CASSANDRA-18190|
> | | | |
> | | | |
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
