[
https://issues.apache.org/jira/browse/CASSANDRA-18156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703255#comment-17703255
]
Brandon Williams commented on CASSANDRA-18156:
----------------------------------------------
I looked into this a bit and we can see that none of the mentioned commits
broke this if we reorder the asserts to check the nodetool output first:
{noformat}
test_deprecated_repair_error_notification failed and was not selected for rerun.
<class 'AssertionError'>
Legacy nodetool didn't print an error message for the failed repair
assert -1 > -1
+ where -1 = <built-in method find of str object at 0x7f375d70fe70>('error')
+ where <built-in method find of str object at 0x7f375d70fe70> = "nodetool:
Failed to connect to 'localhost:7100' - URISyntaxException: 'Malformed IPv6
address at index 7: rmi://[localhost]:7100'.\n".find
[<TracebackEntry
/home/drift/cassandra-dtest/repair_tests/deprecated_repair_test.py:270>]
{noformat}
I did this and adding legacy parsing to the 2.1 side.
||Branch||CI||
|[3.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18156-3.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/913/workflows/9f61a183-9cad-4145-9859-8031592d1fd3]|
|[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-18156-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/914/workflows/19c0deff-a592-4906-8439-d1427123bd31]|
> Test Failure:
> repair_tests.deprecated_repair_test.TestDeprecatedRepairNotifications.test_deprecated_repair_error_notification
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18156
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18156
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
> Reporter: Michael Semb Wever
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Failing since
> https://ci-cassandra.apache.org/job/Cassandra-3.0/313/testReport/dtest.repair_tests.deprecated_repair_test/TestDeprecatedRepairNotifications
> which is
> https://github.com/apache/cassandra/commit/13d495aa7d5b7a7c121fcc9e105f79107c5c2a1c
> from CASSANDRA-17254
> but can be reproduced earlier in circleci, e.g.
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/64/workflows/f99abc05-aa9b-42de-a424-44ab7c247e76/jobs/3175
>
> Only two commits are in this time-range (10th to 30th November) in
> cassandra-dtest
> -
> https://github.com/apache/cassandra-dtest/commit/7f2b8eda5c52fb6f637aa7166e2d48cd34a64eec
> (CASSANDRA-17679)
> -
> https://github.com/apache/cassandra-dtest/commit/e0d3cc90558a17b63634d15ee6df339ceb87b225
> (CASSANDRA-15402)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
