[
https://issues.apache.org/jira/browse/CASSANDRA-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684047#comment-17684047
]
Derek Chen-Becker commented on CASSANDRA-17979:
-----------------------------------------------
I think that the problem is
https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/net/HandshakeTest.java#L384.
The previous line calls {{isConnected}}, which only checks the state of the
connection, not whether the connection has pending data. Given that the test
appears to want to just test connection fallback, I think that the check for
pending messages is unnecessary. I'll submit a patch to remove that check.
> Fix flaky
> test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
> ---------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17979
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17979
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
> Reporter: Brandon Williams
> Assignee: Derek Chen-Becker
> Priority: Normal
> Fix For: 4.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1339/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_cdc/
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1336/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_compression/
> https://app.circleci.com/pipelines/github/instaclustr/cassandra/1466/workflows/ffb52616-92d7-4089-a0c9-a9ebf28333c0/jobs/6296/tests
> {noformat}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:384)
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:243)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
