[
https://issues.apache.org/jira/browse/CASSANDRA-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652521#comment-17652521
]
Paulo Motta edited comment on CASSANDRA-16418 at 12/28/22 3:22 PM:
-------------------------------------------------------------------
Nice work [~linzuro]! The approach and test looks mostly good to me, added a
few comments to the PR.
Can you add a similar regression test for bootstrap so we can detect if this is
ever broken in the future? The test should fail when the bootstrap safeguard is
removed. I think you can find some bootstrap dtest examples on
{{{}org.apache.cassandra.distributed.test.ring.BootstrapTest{}}}.
I have submitted a preliminary CI run for your branch on:
* [https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2151/]
was (Author: paulo):
Nice work [~linzuro]! The approach and test looks mostly good to me, added a
few comments to the PR.
Can you add a similar regression test for bootstrap? The test should fail when
the bootstrap safeguard is removed. I think you can find some bootstrap dtest
examples on \{{org.apache.cassandra.distributed.test.ring.BootstrapTest}}.
I have submitted a preliminary CI run for your branch on:
* https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2151/
> Unsafe to run nodetool cleanup during bootstrap or decommission
> ---------------------------------------------------------------
>
> Key: CASSANDRA-16418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16418
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Bootstrap and Decommission
> Reporter: James Baker
> Assignee: Lindsey Zurovchak
> Priority: Normal
> Time Spent: 20m
> Remaining Estimate: 0h
>
> What we expected: Running a cleanup is a safe operation; the result of
> running a query after a cleanup should be the same as the result of running a
> query before a cleanup.
> What actually happened: We ran a cleanup during a decommission. All the
> streamed data was silently deleted, the bootstrap did not fail, the cluster's
> data after the decommission was very different to the state before.
> Why: Cleanups do not take into account pending ranges and so the cleanup
> thought that all the data that had just been streamed was redundant and so
> deleted it. We think that this is symmetric with bootstraps, though have not
> verified.
> Not sure if this is technically a bug but it was very surprising (and
> seemingly undocumented) behaviour.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
