[ 
https://issues.apache.org/jira/browse/CASSANDRA-17885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620373#comment-17620373
 ] 

Ekaterina Dimitrova commented on CASSANDRA-17885:
-------------------------------------------------

Is there anything else we should do here?

I also don't see any more errors. Thanks

Also I guess upgrade tests only run in Circle is enough as the latest changes 
were test oriented and we had already clear Python DTest runs?

I see there were some commits to the DTest repo since 7th October when you ran 
CI but it seems at most we should just run some of the changed tests locally to 
ensure they are fine and move on to commit this patch. WDYT?

> Add solution for CASSANDRA-17581 to older branches for tests
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-17885
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17885
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tool/nodetool
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> Some of our tests use old branches for the purposes of testing upgrades and 
> behavior in mixed versions, but those lacking CASSANDRA-17581 will fail on 
> nodetool with a modern JDK.  We can port this fix to those branches and 
> adjust the tests to use the newest version of them to solve this going 
> forward.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to