[
https://issues.apache.org/jira/browse/CASSANDRA-17753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620184#comment-17620184
]
Stefan Miklosovic commented on CASSANDRA-17753:
-----------------------------------------------
I looked into this.
When trying it build without git command, I am getting this. It seems to be not
related to this ticket but it is already existing problem and we should fix it
(probably as part of this ticket, why not).
{code:java}
_rat_init:
_build_ratinclude:
[exec] Execute failed: java.io.IOException: Cannot run program "git" (in
directory "/home/smiklosovic/test/cassandra-CASSANDRA-17753"): error=2, No such
file or directory
BUILD FAILED
/home/smiklosovic/test/cassandra-CASSANDRA-17753/.build/build-rat.xml:38:
"Warning: Could not find file
/home/smiklosovic/test/cassandra-CASSANDRA-17753/build/.versioned_files to copy
{code}
Also, it would be nice to include hash into logs, we have this in place already
when Cassandra starts:
{code}
INFO [main] 2022-10-19 12:21:22,188 StorageService.java:790 - Cassandra
version: 4.2-SNAPSHOT
INFO [main] 2022-10-19 12:21:22,189 StorageService.java:792 - CQL version:
3.4.6
{code}
Why not to print it like this?
{code}
INFO [main] 2022-10-19 12:21:22,188 StorageService.java:790 - Cassandra
version: 4.2-SNAPSHOT
INFO [main] 2022-10-19 12:21:22,188 StorageService.java:791 - Git SHA:
45b917fd2043c338eb62b31249988fe54d7f9122-dirty
INFO [main] 2022-10-19 12:21:22,189 StorageService.java:792 - CQL version:
3.4.6
{code}
By doing this, we can call jmx programmatically via StorageServiceMBean, we can
do nodetool version --verbose and we have it in logs as well. We will have that
in system_views.system_logs virtual table as well (CASSANRA-17948) if one
decides to use appender to virtual table on INFO and up.
I will investigate what's up with rat failure.
> Include GitSHA in nodetool version output
> -----------------------------------------
>
> Key: CASSANDRA-17753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17753
> Project: Cassandra
> Issue Type: New Feature
> Components: Tool/nodetool
> Reporter: Abe Ratnofsky
> Assignee: Abe Ratnofsky
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> It can be useful to see specifically which Git SHA a running instance of
> Cassandra was built with, especially when running clusters in development for
> soak testing.
>
> I have a patch ready for this, and am preparing it now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
