[ https://issues.apache.org/jira/browse/CASSANDRA-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599156#comment-17599156 ]
Brandon Williams commented on CASSANDRA-8612: --------------------------------------------- It seems like this is going to touch topReadPartitionFrequency and row cache hits/misses, is that correct? That seems like it could surprise people on upgrade to me. > Read metrics should be updated on all types of reads > ---------------------------------------------------- > > Key: CASSANDRA-8612 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8612 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics > Reporter: Chris Lohfink > Assignee: Dean Z > Priority: Low > Labels: lhf, metrics > Attachments: 0001-Update-read-metrics-on-all-types-of-reads.patch, > 0002-Add-more-read-metrics-into-PartitionRangeReadCommand.patch > > > Metrics like "sstables per read" are not updated on a range slice. Although > separating things out for each type of read could make sense like we do for > latencies, only exposing the metrics for one type can be a little confusing > when people do a query and see nothing increases. I think its sufficient to > use the same metrics for all reads. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org