[ https://issues.apache.org/jira/browse/CASSANDRASC-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520797#comment-17520797 ]
ASF subversion and git services commented on CASSANDRASC-34: ------------------------------------------------------------ Commit 7a5e710a2173e492907edc4094e052157a562103 in cassandra-sidecar's branch refs/heads/trunk from Francisco Guerrero [ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=7a5e710 ] CASSANDRASC-34: Allow for LoggerHandler to be injected Currently, `vertxRouter` adds an instance of `LoggerHandler` to the top level route. This is prescriptive and it doesn't allow for a different implementation of the LoggerHandler to be injected. In this commit, `LoggerHandler` is created in the `MainModule` as a singleton and then injected in the `vertxRouter` method. This allows for a new implementation of the `LoggerHandler` to be provided. > Allow injecting a LoggerHandler to vertxRouter > ---------------------------------------------- > > Key: CASSANDRASC-34 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-34 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration > Reporter: Francisco Guerrero > Assignee: Francisco Guerrero > Priority: Normal > Labels: pull-request-available > > Currently, {{vertxRouter}} _creates_ an instance of {{LoggerHandler}} to the > top level route. This is prescriptive and it doesn't allow for a different > implementation of the {{LoggerHandler}} to be injected. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org