[ 
https://issues.apache.org/jira/browse/CASSANDRA-17493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520529#comment-17520529
 ] 

Paulo Motta commented on CASSANDRA-17493:
-----------------------------------------

Looks good to me - can you just clarify why this was changed?
{code:java}
        if (isShutDown)
-            throw new IllegalStateException("HintsService has already been 
shut down");
+        {
+            logger.warn("HintsService has already been shut down");
+            return;
+        }
{code}

> Shutdown all ScheduledExecutors as part of node drainage
> --------------------------------------------------------
>
>                 Key: CASSANDRA-17493
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17493
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Core
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 4.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We are currently shutting down only non-periodic executors in 
> StorageService#drain. We should shut down all of them. As of now, there does 
> not seem to be any reason why these executors should be active.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to