[ 
https://issues.apache.org/jira/browse/CASSANDRASC-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Joshi updated CASSANDRASC-34:
------------------------------------
    Status: Review In Progress  (was: Patch Available)

Hi Francisco, the patch looks good. The only thing I would recommend is adding 
an automated test if its possible. If its too complicated its OK.

> Allow injecting a LoggerHandler to vertxRouter
> ----------------------------------------------
>
>                 Key: CASSANDRASC-34
>                 URL: https://issues.apache.org/jira/browse/CASSANDRASC-34
>             Project: Sidecar for Apache Cassandra
>          Issue Type: Improvement
>          Components: Configuration
>            Reporter: Francisco Guerrero
>            Assignee: Francisco Guerrero
>            Priority: Normal
>
> Currently, {{vertxRouter}} _creates_ an instance of {{LoggerHandler}} to the 
> top level route. This is prescriptive and it doesn't allow for a different 
> implementation of the {{LoggerHandler}} to be injected.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to