[ 
https://issues.apache.org/jira/browse/CASSANDRA-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247888#comment-17247888
 ] 

Andres de la Peña commented on CASSANDRA-16311:
-----------------------------------------------

[~stefan.miklosovic] thanks. I'm running a final CI round here:
||branch||utest||python-dtest||java-dtest||
|3.0|[129|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/129/]|[279|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/279/]|[124|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-jvm-dtest/124/]|
|3.11|[130|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/130/]|[280|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/280/]|[125|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-jvm-dtest/125/]|
|trunk|[131|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/131/]|[281|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/281/]|[126|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-jvm-dtest/126/]|

If it's ok with you I'll add the following to the JavaDoc of the new method 
during commit:
{code:java}
Replica filtering protection might need to run the query row filter in the 
coordinator to detect stale results. An index implementation will be compatible 
with this protection mechanism if it returns the same results for the row 
filter as CQL will return with {@code ALLOW FILTERING} and without using the 
index. This means that index implementations using custom query syntax or 
applying transformations to the indexed data won't support it.
See CASSANDRA-8272 for further details.
{code}
 

> Extend the exclusion of replica filtering protection to other indices instead 
> of just SASI
> ------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16311
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16311
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/2i Index, Feature/SASI
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0-beta
>
>
> There was a check introduced in CASSANDRA-8272 telling if an index is a SASI 
> index and if it is, replica filtering protection was not triggered.
> There might be other custom index implementations which also do not support 
> filtering protection and they do not have to be SASI indices neccessarily, 
> however it is not possible to exclude them.
>  
> PR trunk
> [https://github.com/apache/cassandra/pull/844]
> PR 3.11
> [https://github.com/apache/cassandra/pull/847]
> PR 3.0
> https://github.com/apache/cassandra/pull/848
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to