[ 
https://issues.apache.org/jira/browse/CASSANDRA-15953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162971#comment-17162971
 ] 

Yifan Cai commented on CASSANDRA-15953:
---------------------------------------

Thanks for the review. 

Regarding the {{disallowed_keyspaces}} list, I vacillated between either 1) 
using the list as an addition to the predefined system keyspaces list or 2) 
using it explicitly (so the logic is either client provides a list to ignore or 
a predefined list is used). I picked the later one. But looks like it causes 
confusion. 
Given there is really no point of comparing system tables, the current 
implementation that allows it does not make sense. 

The PR was updated to address the comment. 

> Support fetching all user tables to compare in Cassandra-diff
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-15953
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15953
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/diff
>            Reporter: Yifan Cai
>            Assignee: Yifan Cai
>            Priority: Normal
>              Labels: pull-request-available
>
> The spark diff job may fail to launch with kernel error "E2BIG: Argument list 
> too long", when passing a large list of keyspace table list to compare. 
> Proposing a mode to fetch all user tables from the clusters to be compared. 
> When the mode is on, the spark job ignores the parameter "keyspace_tables".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to