[
https://issues.apache.org/jira/browse/CASSANDRA-15842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126767#comment-17126767
]
Benjamin Lerer commented on CASSANDRA-15842:
--------------------------------------------
The fix looks good. I just wonder if we should not simply make the
{{CDCSizeTracker.shutdown()}} more robust. Something like:
{code:java}
public void shutdown()
{
if (cdcSizeCalculationExecutor != null &&
!cdcSizeCalculationExecutor.isShutdown())
{
cdcSizeCalculationExecutor.shutdown();
}
}
{code}
Throwing a NPE when the {{CDCSizeTracker}} is not started is not the nicest
behavior.
> Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-15842
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15842
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Failing for the past [28
> builds|https://ci-cassandra.apache.org/job/Cassandra-trunk/153/testReport/org.apache.cassandra.schema/SchemaTest/testTransKsMigration_cdc/]
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312)
> at
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413)
> at
> org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467)
> at
> org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785)
> at
> org.apache.cassandra.schema.SchemaTest.testTransKsMigration(SchemaTest.java:46)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
