[
https://issues.apache.org/jira/browse/CASSANDRA-15704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17080018#comment-17080018
]
Jon Haddad commented on CASSANDRA-15704:
----------------------------------------
I've removed the handler from the pipeline and moved the metric logic into the
Frame encoder and decoder, and did a little cleanup.
I renamed the test to ServerMetricsTest, since I didn't see anything meant for
that purpose and it felt a little odd to write a test where all it does it
check on 2 metrics. If there's other metrics we log during the native protocol
I'm thinking it will be obvious to do it here.
I also spot checked the stats coming out of the server, we're definitely not
double counting now.
[J8
DTest|https://app.circleci.com/pipelines/github/rustyrazorblade/cassandra/31/workflows/7eecc28e-2d94-4c16-b538-49c001d85a7f/jobs/320]
and [Unit
Tests|https://app.circleci.com/pipelines/github/rustyrazorblade/cassandra/31/workflows/7eecc28e-2d94-4c16-b538-49c001d85a7f/jobs/315].
> add client request size metrics to netty pipeline
> -------------------------------------------------
>
> Key: CASSANDRA-15704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15704
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
> Reporter: Jon Haddad
> Assignee: Jon Haddad
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We currently lack metrics around client connection incoming / outgoing bytes.
> It’s fairly standard to know how many bytes are read and written to the
> network, but that aggregates client facing and internal cluster traffic to a
> single number. This patch will help us understand client overhead more
> granularly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
