[
https://issues.apache.org/jira/browse/CASSANDRA-15461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eriksson updated CASSANDRA-15461:
----------------------------------------
Status: Ready to Commit (was: Review In Progress)
+1
few extremely minor nits that you can ignore or fix on commit:
In {{Digest}}:
* maybe use {{ThreadLocal.withInitial}} for creating {{localBuffer}}
* {{public Digest update(ByteBuffer input, int pos, int len)}} can be private
* update javadoc comment on {{public Digest updateWithCounterContext(ByteBuffer
context)}} (it is not "{{updateDigest}}" anymore)
In {{UnfilteredPartitionIterators}}:
* double indentation on {{UnfilteredRowIterators.digest(partition, digest,
version);}} in {{public static void digest(...)}}
> Legacy counter shards can cause false positives in repaired data tracking
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-15461
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15461
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
> Reporter: Sam Tunnicliffe
> Assignee: Sam Tunnicliffe
> Priority: Normal
> Fix For: 4.0-beta
>
>
> It is expected that the serialization of legacy (pre-2.1) counter cells may
> differ across replicas due to the remote vs local designation of the shards.
> This will cause the repaired data digests calculated at read time to differ
> where certain legacy shards are encountered. This does not, however, indicate
> corruption of the repaired dataset and there isn't any action that operators
> can take in this scenario. Excluding counter cells which contain legacy
> shards from the digest calculation will avoid false positives.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
