[
https://issues.apache.org/jira/browse/CASSANDRA-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836680#comment-16836680
]
eBugs commented on CASSANDRA-15111:
-----------------------------------
Thanks a lot Jon! Your explanation make sense to me. Even if the exception will
not be logged at the default level, I think it can still be helpful to wrap the
cause exception, especially for debugging purpose.
Thanks for tagging this for 4.x.
> StorageService.move() throws RuntimeException when interrupted
> --------------------------------------------------------------
>
> Key: CASSANDRA-15111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15111
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX, Tool/nodetool
> Reporter: eBugs
> Priority: Low
> Fix For: 4.x
>
>
> Dear Cassandra developers, we are developing a tool to detect
> exception-related bugs in Java. Our prototype has spotted the following
> {{throw}} statement whose exception class and error message indicate
> different error conditions.
>
> Version: Cassandra-3.11 (commit: 123113f7b887370a248669ee0db6fdf13df0146e)
> File: CASSANDRA-ROOT/src/java/org/apache/cassandra/service/StorageService.java
> Line: 4168
> {code:java}
> try
> {
> relocator.stream().get();
> }
> catch (ExecutionException | InterruptedException e)
> {
> throw new RuntimeException("Interrupted while waiting for stream/fetch
> ranges to finish: " + e.getMessage());
> }
> {code}
>
> {{RuntimeException}} is usually used to represent errors in the program logic
> (think of one of its subclasses, {{NullPointerException}}), while the error
> message indicates that an interrupt has occurred. This mismatch could be a
> problem. For example, the callers may miss the possibility that
> {{StorageService.move()}} can be interrupted because it does not throw any
> {{InterruptedException}}. Or, the callers trying to handle other
> {{RuntimeException}} may accidentally (and incorrectly) handle the interrupt.
>
> If throwing a {{RuntimeException}} is preferred, maybe it can wrap the cause
> exception so that the inner call stack is preserved.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
