[ 
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626318#comment-16626318
 ] 

Joshua McKenzie commented on CASSANDRA-14772:
---------------------------------------------

{quote}I've looked up [the original discussion 
thread|https://lists.apache.org/thread.html/61f29a67b4570dac87047f64b846c6f83e8bcb39b6b67143c9a485c2@%3Cdev.cassandra.apache.org%3E],
 and the predominant phrasing was "feature freeze"
{quote}
Ah hah - there's our disconnect. I incorrectly recalled us discussing it as a 
*code freeze*, not a *feature freeze*.
 Two very different things. Refactor away to your heart's content, I won't 
fight it. :)

And fwiw - I'm in no way advocating for us to never refactor code; just take a 
look at the CommitLogReader during the CDC impl time frame. I'm against 
refactors post *code freeze*, which is irrelevant given the earlier 
misunderstanding.

Carry on, sorry for the unnecessary traffic.

> Fix issues in audit / full query log interactions
> -------------------------------------------------
>
>                 Key: CASSANDRA-14772
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14772
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Major
>             Fix For: 4.0
>
>
> There are some problems with the audit + full query log code that need to be 
> resolved before 4.0 is released:
> * Fix performance regression in FQL that makes it less usable than it should 
> be.
> * move full query log specific code to a separate package 
> * do some audit log class renames (I keep reading {{BinLogAuditLogger}} vs 
> {{BinAuditLogger}} wrong for example)
> * avoid parsing the CQL queries twice in {{QueryMessage}} when audit log is 
> enabled.
> * add a new tool to dump audit logs (ie, let fqltool be full query log 
> specific). fqltool crashes when pointed to them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to