[
https://issues.apache.org/jira/browse/CASSANDRA-14626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587227#comment-16587227
]
Benedict commented on CASSANDRA-14626:
--------------------------------------
Patch looks like a big improvement. I have a couple of minor suggestions for
{{CacheMetrics}}:
# Modernise all of the {{RatioGauge}} construction as well, via a static method
that accepts a {{Supplier<Ratio>}}
# Replace {{requests}} with a {{Metered}} that proxies its calls to {{getX}}
onto {{hits.getX() + misses.getX()}}
I've pushed a patch with these changes
[here|https://github.com/belliottsmith/cassandra/tree/14626-suggest]. Feel
free to take or discard as you please.
+1
> Expose buffer cache metrics in caches virtual table
> ---------------------------------------------------
>
> Key: CASSANDRA-14626
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14626
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Benjamin Lerer
> Assignee: Aleksey Yeschenko
> Priority: Minor
> Labels: virtual-tables
> Fix For: 4.0
>
>
> As noted by [~blerer] in CASSANDRA-14538, we should expose buffer cache
> metrics in the caches virtual table.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
