[
https://issues.apache.org/jira/browse/CASSANDRA-14563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567652#comment-16567652
]
mck commented on CASSANDRA-14563:
---------------------------------
{quote}One thing I like about the docker approach is that we really know that
Cassandra will really work with that JVM. We can build with whichever JVMs we
want to support building on and we can run the unit tests using whichever JVMs
we claim to support running on.
{quote}
[~jolynch], i agree with this notion. It demonstrates the separation of
concerns between jdk compatibility: source&binary compatibility and
functional/behavioural compatibility.
We only (afaik so far) want to build with jdk8.
We do want to test (more integration tests) against multiple JVMs.
AnimalSniffer allows us to drop concerns about source compatibility, and drop
having to run integration tests over artefacts built with jdk7. That's kinda
important because the community never publishes jdk7 built artefacts.
An improved testing environment would definitely be welcome (eg with docker)
and integration tests can (should) be run over all jdk patch versions that we
say we support (because functional compatibility is not just defined by major
versions).
But the intention of this ticket was to introduce AnimalSniffer so to deal with
(and simplify) source and binary compatibility, and provide a much faster dev
feedback loop than CircleCi ever could. As stated, I really don't think that
there's ever a need to compile Cassandra with multiple JDKs, it doesn't give us
anything and only adds an additional variable into the testing matrix.
While we should be doing more for functional testing against different jvms
versions, that's really outside the scope of this ticket.
[~sumanth.pasupuleti], would you mind creating a separate jira ticket for your
pull request.
> Add animalsniffer to build to ensure runtime jdk compatbility
> -------------------------------------------------------------
>
> Key: CASSANDRA-14563
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14563
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
> Reporter: mck
> Assignee: Sumanth Pasupuleti
> Priority: Minor
> Labels: lhf
>
> Cassandra-2.2 still supports running on JDK1.7
> No tests check this though, as all build and test with JDK1.8
> Adding the ant animalsniffer task can check that jdk1.8 classes or methods
> are not used accidentally.
> ref: http://www.mojohaus.org/animal-sniffer/animal-sniffer/index.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
