[
https://issues.apache.org/jira/browse/CASSANDRA-14504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515955#comment-16515955
]
Sam Tunnicliffe commented on CASSANDRA-14504:
---------------------------------------------
LGTM (minus the circle yaml change ofc)
> fqltool should open chronicle queue read only and a GC bug
> ----------------------------------------------------------
>
> Key: CASSANDRA-14504
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14504
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Reporter: Ariel Weisberg
> Assignee: Ariel Weisberg
> Priority: Major
> Fix For: 4.0
>
>
> There are two issues with fqltool.
> The first is that it doesn't open the chronicle queue read only so it won't
> work if it doesn't have write permissions and it's not clear if it's safe to
> open the queue to write if the server is also still appending.
> The next issue is that NativeBytesStore.toTemporaryDirectByteBuffer() returns
> a ByteBuffer that doesn't strongly reference the memory it refers to
> resulting it in sometimes being reclaimed and containing the wrong data when
> we go to read from it. At least that is the theory. Simple solution is to use
> toByteArray() and that seems to make it work consistently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
