[
https://issues.apache.org/jira/browse/CASSANDRA-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480683#comment-16480683
]
Benjamin Lerer commented on CASSANDRA-7622:
-------------------------------------------
Sorry, for the delay of my review.
As discussed with [~iamaleksey] offline, I have 2 concerns with the final patch.
# It feels wrong to me that we have to reconstruct the {{VirtualKeyspace}},
{{VirtualTable}} and {{VirtualColumns}} dataset everytime they are queried
taking into account that for the moment they will never change after startup.
As Aleksey pointed out it is really cheap but still it is bothering me. Now, I
might be the only one with that feeling and we can still change that easily
later if needed.
# We will probably use virtual tables for different functionalities in the
future (e.g. system views, foreign data mapper ...). For the user they should
appear as different functionalities even if they are implemented on top of
virtual tables. So, I believe that we should modify the schema change
validation errors to display the name of the specific functionality instead of
{{virtual tables}}. Aleksey proposed to fix that as part of CASSANDRA-13426
which is fine with me.
Outside of that I only found 2 small nits that can be fixed on commit.
* The message change
[here|https://github.com/iamaleksey/cassandra/commit/020202e698c654123fe90bffd01f46c412311794#diff-ac79f1ada9707ae283908e7ca8844cacL157]
look like a mistake to me.
* The class javadoc in {{VirtualTableReadQuery}},
{{VirtualTablePartitionRangeReadQuery}} and
{{VirtualTableSinglePartitionReadQuery}} are referring to system views instead
of virtual tables.
+1
Thanks a lot to everybody for the hard work. I will be really happy to see that
ticket committed and I know that I am not the only one :-).
> Implement virtual tables
> ------------------------
>
> Key: CASSANDRA-7622
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7622
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL
> Reporter: Tupshin Harper
> Assignee: Chris Lohfink
> Priority: Major
> Fix For: 4.0
>
> Attachments: screenshot-1.png
>
>
> There are a variety of reasons to want virtual tables, which would be any
> table that would be backed by an API, rather than data explicitly managed and
> stored as sstables.
> One possible use case would be to expose JMX data through CQL as a
> resurrection of CASSANDRA-3527.
> Another is a more general framework to implement the ability to expose yaml
> configuration information. So it would be an alternate approach to
> CASSANDRA-7370.
> A possible implementation would be in terms of CASSANDRA-7443, but I am not
> presupposing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
