[ 
https://issues.apache.org/jira/browse/CASSANDRA-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018018#comment-13018018
 ] 

Jeremy Hanna commented on CASSANDRA-1263:
-----------------------------------------

+1 - changes look good to me. May need to be rebased before committing. Also 
schema sample could use a NTS example, but not necessary.  Overall, it seems 
like NTS needs some documentation love with the amount of use it gets - but 
maybe that's for a blog post or at least another ticket.  Sorry for the belated 
updated review.

> Push replication factor down to the replication strategy
> --------------------------------------------------------
>
>                 Key: CASSANDRA-1263
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1263
>             Project: Cassandra
>          Issue Type: Task
>          Components: Core
>            Reporter: Jeremy Hanna
>            Assignee: Jon Hermes
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: 1263-2.txt, 1263-3.txt, 1263-4.txt, 1263-5.txt, 
> 1263-incomplete.txt, 1263.txt
>
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> Currently the replication factor is in the keyspace metadata.  As we've added 
> the datacenter shard strategy, the replication factor becomes more computed 
> by the replication strategy.  It seems reasonable to therefore push the 
> replication factor for the keyspace down to the replication strategy so that 
> it can be handled in one place.
> This adds on the work being done in CASSANDRA-1066 since that ticket will 
> make the replication strategy a member variable of keyspace metadata instead 
> of just a quasi singleton giving the replication strategy state for each 
> keyspace.  That makes it able to have the replication factor.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to