[ 
https://issues.apache.org/jira/browse/CASSANDRA-10857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240539#comment-16240539
 ] 

Alex Petrov commented on CASSANDRA-10857:
-----------------------------------------

Thank you for the review,

I did run CI multiple times, re-ran the rebased version once again just in 
case. Might still cause some intermediate failures because of non-atomic dtest 
commit. All test failures across all branches were fixed.

Committed to 3.0 as 
[6c29ee84a2f62ccd05c328bbaa0c364eb1a7a821|https://github.com/apache/cassandra/commit/6c29ee84a2f62ccd05c328bbaa0c364eb1a7a821],
 merged up to 
[3.11|https://github.com/apache/cassandra/commit/6d429cd0315d3509c904d0e83f91f7d12ba12085]
 and 
[trunk|https://github.com/apache/cassandra/commit/38bd20e0510048c3c93781afd05efdf31594c115].
 Second trunk commit (minimal trunk patch) is committed as 
[07fbd8ee6042797aaade90357d625ba9d79c31e0|https://github.com/apache/cassandra/commit/07fbd8ee6042797aaade90357d625ba9d79c31e0].

As discussed offline, phrasing didn't change as schema movements are not 
permitted across the versions. I'll get dtests committed 

The follow-up ticket for removing the compact storage code internally is 
[CASSANDRA-13994].

> Allow dropping COMPACT STORAGE flag from tables in 3.X
> ------------------------------------------------------
>
>                 Key: CASSANDRA-10857
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10857
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL, Distributed Metadata
>            Reporter: Aleksey Yeschenko
>            Assignee: Alex Petrov
>            Priority: Blocker
>              Labels: client-impacting
>             Fix For: 3.0.x, 3.11.x
>
>
> Thrift allows users to define flexible mixed column families - where certain 
> columns would have explicitly pre-defined names, potentially non-default 
> validation types, and be indexed.
> Example:
> {code}
> create column family foo
>     and default_validation_class = UTF8Type
>     and column_metadata = [
>         {column_name: bar, validation_class: Int32Type, index_type: KEYS},
>         {column_name: baz, validation_class: UUIDType, index_type: KEYS}
>     ];
> {code}
> Columns named {{bar}} and {{baz}} will be validated as {{Int32Type}} and 
> {{UUIDType}}, respectively, and be indexed. Columns with any other name will 
> be validated by {{UTF8Type}} and will not be indexed.
> With CASSANDRA-8099, {{bar}} and {{baz}} would be mapped to static columns 
> internally. However, being {{WITH COMPACT STORAGE}}, the table will only 
> expose {{bar}} and {{baz}} columns. Accessing any dynamic columns (any column 
> not named {{bar}} and {{baz}}) right now requires going through Thrift.
> This is blocking Thrift -> CQL migration for users who have mixed 
> dynamic/static column families. That said, it *shouldn't* be hard to allow 
> users to drop the {{compact}} flag to expose the table as it is internally 
> now, and be able to access all columns.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to