[ 
https://issues.apache.org/jira/browse/CASSANDRA-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088829#comment-16088829
 ] 

Jeff Jirsa commented on CASSANDRA-13526:
----------------------------------------

Thanks [~jasonstack] .  I glanced at it and it looked reasonable, though I'll 
do a more thorough review next week.

Since it's a bug fix (and a pretty serious one at that), it seems like we 
should have patches for at least 3.0 and 3.11 , and perhaps even 2.1 and 2.2. 
Are you able to port your fix to 3.0 and 3.11? 

We should also add a unit test to make sure we prevent this sort of regression 
again in the future.





> nodetool cleanup on KS with no replicas should remove old data, not silently 
> complete
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13526
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13526
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Jeff Jirsa
>            Assignee: ZhaoYang
>              Labels: usability
>             Fix For: 2.2.x, 3.0.x, 3.11.x, 4.x
>
>
> From the user list:
> https://lists.apache.org/thread.html/5d49cc6bbc6fd2e5f8b12f2308a3e24212a55afbb441af5cb8cd4167@%3Cuser.cassandra.apache.org%3E
> If you have a multi-dc cluster, but some keyspaces not replicated to a given 
> DC, you'll be unable to run cleanup on those keyspaces in that DC, because 
> [the cleanup code will see no ranges and exit 
> early|https://github.com/apache/cassandra/blob/4cfaf85/src/java/org/apache/cassandra/db/compaction/CompactionManager.java#L427-L441]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to