[
https://issues.apache.org/jira/browse/CASSANDRA-13592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072449#comment-16072449
]
Benjamin Lerer commented on CASSANDRA-13592:
--------------------------------------------
The patch looks mostly good. I just have the following nits:
* The unit test: {{JsonTest::testPagingWithJsonQuery}} is hard to read. It
seems to me that the loop does not bring much and makes the code harder to
understand. I would remove it, even if it results in a longer method.
* In the same method you should check the output and not only the number of
rows. The returned values could be invalid even if the number of returned rows
is the good one.
* I would replace {{/** Converts a value to a JSON string. buffer position not
changed */}} by something like:
{code}
/**
* Converts the specified value into its JSON representation.
* <p>The buffer position will stay the same.</p>
* @param buffer the value to convert
* @param protocolVersion the protocol version to use for the conversion
* @return a JSON string representing the specified value
*/
{code}
> Null Pointer exception at SELECT JSON statement
> -----------------------------------------------
>
> Key: CASSANDRA-13592
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13592
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
> Environment: Debian Linux
> Reporter: Wyss Philipp
> Assignee: ZhaoYang
> Labels: beginner
> Attachments: system.log
>
>
> A Nulll pointer exception appears when the command
> {code}
> SELECT JSON * FROM examples.basic;
> ---MORE---
> <Error from server: code=0000 [Server error]
> message="java.lang.NullPointerException">
> Examples.basic has the following description (DESC examples.basic;):
> CREATE TABLE examples.basic (
> key frozen<tuple<uuid, int>> PRIMARY KEY,
> wert text
> ) WITH bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = '99PERCENTILE';
> {code}
> The error appears after the ---MORE--- line.
> The field "wert" has a JSON formatted string.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
