[ 
https://issues.apache.org/jira/browse/CASSANDRA-11720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649054#comment-15649054
 ] 

mck edited comment on CASSANDRA-11720 at 11/8/16 10:53 PM:
-----------------------------------------------------------

LGTM.

Some small feedback [~hnishi]:
  • can we add a test?
      ∘  dtest (nodetool_test.py) (or a unit test if something can be created…)
  • the docs need to be updated
      ∘ we'd need an entry in {{doc/build/html/tools/nodetool/nodetool.html}}
  • CHANGES.txt needs an entry


was (Author: michaelsembwever):
LGTM.

Some small feedback [~hnishi]:
  • can we add a test?
      ∘  dtest (nodetool_test.py) (or a unit test if something can be created…)
  • the docs need to be updated
      ∘ we'd need an entry in {{doc/build/html/tools/nodetool/nodetool.html}}
  • CHANGES.txt needs an update again

> Changing `max_hint_window_in_ms` at runtime
> -------------------------------------------
>
>                 Key: CASSANDRA-11720
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11720
>             Project: Cassandra
>          Issue Type: Wish
>          Components: Coordination
>            Reporter: Jens Rantil
>            Priority: Minor
>              Labels: lhf
>         Attachments: CASSANDRA-11720-trunk.patch
>
>
> Scenario: A larger node (in terms of data it holds) goes down. You realize 
> that it will take slightly more than `max_hint_window_in_ms` to fix it. You 
> have a the disk space to store some additional hints.
> Proposal: Support changing `max_hint_window_in_ms` at runtime. The change 
> doesn't have to be persisted somewhere. I'm thinking similar to changing the 
> `compactionthroughput` etc. using `nodetool`.
> Workaround: Change the value in the configuration file and do a rolling 
> restart of all the nodes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to