[
https://issues.apache.org/jira/browse/CASSANDRA-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuki Morishita updated CASSANDRA-12503:
---------------------------------------
Status: Open (was: Patch Available)
Thanks for the patch. Here is my review:
- Many objects are declared as Map instead of List. For example, {{States}}
map's value is overwritten every time when iterating over {{StreamState}}s.
- I think {{ProgressInfo}} should be hold as Map instead of String as others.
So basically you should contruct {{List<Map<String, Object>>}} where
{{Map<String, Object}} is basically the copy from each {{StreamState}}.
It is much easier to code and understand if we could just use {{StreamState}}
with
[jackson-databind-annotation|https://github.com/FasterXML/jackson-databind]. To
do this, we need to upgrade our jackson version to 2.x though.
> Structure for netstats output format (JSON, YAML)
> -------------------------------------------------
>
> Key: CASSANDRA-12503
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12503
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Hiroki Watanabe
> Assignee: Hiroki Watanabe
> Priority: Minor
> Fix For: 3.x
>
> Attachments: new_receiving.def, new_receiving.json,
> new_receiving.yaml, new_sending.def, new_sending.json, new_sending.yaml,
> old_receiving.def, old_sending.def, trunk.patch
>
>
> As with nodetool tpstats and tablestats (CASSANDRA-12035), nodetool netstats
> should also support useful output formats such as JSON or YAML, so we
> implemented it.
> Please review the attached patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
