[
https://issues.apache.org/jira/browse/CASSANDRA-12342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407774#comment-15407774
]
Robert Stupp commented on CASSANDRA-12342:
------------------------------------------
Hm - thought about the "fcFdField" again. Refactored it to a "static final"
field and kicked off CI + cstar.
Also worked in the suggested field name changes.
The OS_X field can't be local since it's used in tryMlockall().
(If anything changes for Java9, it will be covered in CASSANDRA-9608.)
> CLibrary improvements
> ---------------------
>
> Key: CASSANDRA-12342
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12342
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
> Fix For: 3.x
>
>
> {{CLibrary}} uses {{FBUtilities.getProtectedField}} for each invocation of
> {{getfd}} - i.e. {{Class.getDeclaredField}} + {{Field.setAccessible}}. Linked
> patch migrates these {{Field}} references to static class fields + adds
> constants for the OS. Also adds a tiny optimization for non-linux OSs in
> {{trySync}}.
> ||trunk|[branch|https://github.com/apache/cassandra/compare/trunk...snazy:CLibrary-opts]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-CLibrary-opts-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-CLibrary-opts-dtest/lastSuccessfulBuild/]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
