[ 
https://issues.apache.org/jira/browse/CASSANDRA-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018397#comment-15018397
 ] 

Paulo Motta commented on CASSANDRA-9474:
----------------------------------------

Thanks for the patches. I submitted a [cassandra-dtest 
PR|https://github.com/riptano/cassandra-dtest/pull/678] and cassci test runs.

Since this is only a startup check, and 2.1.12 wasn't released yet with the 
rack startup check (CASSANDRA-10243) I think it's better to include this patch 
on 2.1 for completeness, so I backported it to 2.1. We should also include it 
on 3.0.1 and 3.1 since the "ignore_rack" flag was removed on 2.2/3.0, but is 
present on 2.1, so removing the flag would be a regression. Below are branches 
and test results:

||2.1||2.2||3.0||3.1||trunk||
|[branch|https://github.com/apache/cassandra/compare/cassandra-2.1...pauloricardomg:2.1-9474]|[branch|https://github.com/apache/cassandra/compare/cassandra-2.2...pauloricardomg:2.2-9474]|[branch|https://github.com/apache/cassandra/compare/cassandra-3.0...pauloricardomg:3.0-9474]|[branch|https://github.com/apache/cassandra/compare/cassandra-3.1...pauloricardomg:3.1-9474]|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-9474]|
|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-2.1-9474-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-2.2-9474-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.0-9474-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.1-9474-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-9474-testall/lastCompletedBuild/testReport/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-2.1-9474-dtest/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-2.2-9474-dtest/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.0-9474-dtest/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.1-9474-dtest/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-9474-dtest/lastCompletedBuild/testReport/]|

Will mark as ready to commit once tests are OK.

> DC/Rack property changed on live system
> ---------------------------------------
>
>                 Key: CASSANDRA-9474
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9474
>             Project: Cassandra
>          Issue Type: Improvement
>         Environment: Cassandra 2.1.5
>            Reporter: Marcus Olsson
>            Assignee: Marcus Olsson
>             Fix For: 2.1.x
>
>         Attachments: CASSANDRA-9474-2.2.patch, CASSANDRA-9474-dtest.patch, 
> CASSANDRA-9474-trunk.patch, cassandra-2.1-9474.patch, 
> cassandra-2.1-dc_rack_healthcheck.patch
>
>
> When using GossipingPropertyFileSnitch it is possible to change the data 
> center and rack of a live node by changing the cassandra-rackdc.properties 
> file. Should this really be possible? In the documentation at 
> http://docs.datastax.com/en/cassandra/2.1/cassandra/initialize/initializeMultipleDS.html
>  it's stated that you should ??Choose the name carefully; renaming a data 
> center is not possible??, but with this functionality it doesn't seem 
> impossible(maybe a bit hard with changing replication etc.).
> This functionality was introduced by CASSANDRA-5897 so I'm guessing there is 
> some use case for this?
> Personally I would want the DC/rack settings to be as restricted as the 
> cluster name, otherwise if a node could just join another data center without 
> removing it's local information couldn't it mess up the token ranges? And 
> suddenly the old data center/rack would loose 1 replica of all the data that 
> the node contains.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to