[
https://issues.apache.org/jira/browse/CASSANDRA-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982847#action_12982847
]
Jonathan Ellis commented on CASSANDRA-1998:
-------------------------------------------
oops, that was without the patch. with the patch, it is 8 in BBU and 12
outside.
> Make offsets in ByteBufferUtil.* methods relatif to the ByteBuffer position()
> -----------------------------------------------------------------------------
>
> Key: CASSANDRA-1998
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1998
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 0001-0.7-Make-BB-offset-relative-to-position.patch,
> 0001-Make-BB-offset-relative-to-position.patch,
> 0002-0.7-Move-EMPTY_BYTE_BUFFER-to-ByteBufferUtil.patch,
> 0002-Move-EMPTY_BYTE_BUFFER-to-ByteBufferUtil.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> A few methods in ByteBufferUtil take as parameter an offset inside a
> ByteBuffer. When we use them, we always want this offset to be relative to
> ByteBuffer.position(), but it is not, it is relative to the ByteBuffer 0
> position. I argue this is not inline with the way we use ByteBuffers and as a
> consequence, is ugly and error-prone.
> This ticket proposes to make the offset of the ByteBufferUtil.* methods
> relatif to the ByteBuffer position.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
