[ 
https://issues.apache.org/jira/browse/CASSANDRA-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936091#comment-14936091
 ] 

Stefania commented on CASSANDRA-10289:
--------------------------------------

Thanks, the patch looks good now. Only one more thing, rather than displaying 
{{99999.99219}} we should try and go back to {{1e+05}} by changing the input 
number from {{99999.99}} to {{99999.999}} in _test_keyspace_init.cql_ . The 
final 219 is a rounding error, the precision of 5 decimal places is too high in 
this case, so I am worried the test could break in future. I should have 
thought about this yesterday really, sorry about the delay.

I'll obviously leave it up to you guys to decide how to best run these tests on 
developers' branches, thanks for picking up my suggestion. 

> Fix cqlshlib tests
> ------------------
>
>                 Key: CASSANDRA-10289
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10289
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Jim Witschey
>            Assignee: Jim Witschey
>              Labels: cqlsh
>             Fix For: 3.0.0 rc2
>
>
> The cqlsh tests in trunk haven't been running for a while:
> http://cassci.datastax.com/view/All_Jobs/job/trunk_cqlshlib/423/testReport/
> This looks like the driver errors that happened because of CASSANDRA-6717. 
> Not sure why it's happening now; the driver installation looks normal to me 
> on those jobs. [~mshuler]?
> There were also some changes to cqlsh itself that also broke the test 
> harness, but I believe those are fixed here:
> https://github.com/mambocab/cassandra/tree/fix-cqlsh-tests
> Once the tests are running successfully on CassCI, I'll test my patch and 
> mark as patch available.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to