[ 
https://issues.apache.org/jira/browse/CASSANDRA-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711217#comment-14711217
 ] 

Sylvain Lebresne commented on CASSANDRA-9901:
---------------------------------------------

bq. This may lead to suboptimal compilation.

In the absence of any evidence that this has any measurable impact (nor, for 
this matter, than this happen in the first place), and given that this makes 
the code more convoluted than necessary, I currently consider this premature 
optimization and maintain my objection to this change. Further, as this ticket 
is not about performance, I would appreciate if you moved that change to a 
separate ticket if you wish to push it further. 

> Make AbstractType.isByteOrderComparable abstract
> ------------------------------------------------
>
>                 Key: CASSANDRA-9901
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9901
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>             Fix For: 3.0 beta 2
>
>
> I can't recall _precisely_ what was agreed at the NGCC, but I'm reasonably 
> sure we agreed to make this method abstract, put some javadoc explaining we 
> may require fields to yield true in the near future, and potentially log a 
> warning on startup if a user-defined type returns false.
> This should make it into 3.0, IMO, so that we can look into migrating to 
> byte-order comparable types in the post-3.0 world.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to