[ 
https://issues.apache.org/jira/browse/CASSANDRA-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275849#comment-14275849
 ] 

Brandon Williams commented on CASSANDRA-7974:
---------------------------------------------

This mostly looks good, but a few things: we aren't supposed to return any kind 
of internals over JMX, only simple types.  While String getKeyValidator() makes 
it easier to print stuff, I don't think that's the right approach or something 
that should be exposed via JMX, either.  Using the tracing stage for this seems 
kind of lazy - do we even really need an async call?

> Enable tooling to detect hot partitions
> ---------------------------------------
>
>                 Key: CASSANDRA-7974
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7974
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Brandon Williams
>            Assignee: Chris Lohfink
>             Fix For: 2.1.3
>
>         Attachments: 7974.txt, cassandra-2.1-7974v2.txt
>
>
> Sometimes you know you have a hot partition by the load on a replica set, but 
> have no way of determining which partition it is.  Tracing is inadequate for 
> this without a lot of post-tracing analysis that might not yield results.  
> Since we already include stream-lib for HLL in compaction metadata, it 
> shouldn't be too hard to wire up topK for X seconds via jmx/nodetool and then 
> return the top partitions hit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to