[ 
https://issues.apache.org/jira/browse/CASSANDRA-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933015#action_12933015
 ] 

Eric Evans commented on CASSANDRA-1705:
---------------------------------------

> About grammar - it's not all about aesthetics, it's about the way how ANTLR 
> guys
> suggest it to be done, "scope" was designed especially to handle such
> situations. On my standpoint it's more readable too.

Could you maybe provide some links to that effect (that this is the 
convention/recommendation)? I could find nothing, (not surprising though since 
the state of ANTLR's docs is, same-as-every-other-floss-project).  I'm not 
trying to be a pain in the ass (honest!) but this pattern is repeated 
throughout the grammar and it's probably best to have this conversation once.

Also, could I get you to provide a patch against this set of patches that 
implements what you are suggesting?  The code above won't work for a variety of 
reasons, and I wasn't immediately able to adapt it since, not to belabor the 
point, but the docs weren't helpful.

Thanks Pavel!

> CQL writes (aka UPDATE)
> -----------------------
>
>                 Key: CASSANDRA-1705
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1705
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: API
>    Affects Versions: 0.8
>            Reporter: Eric Evans
>            Assignee: Eric Evans
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: CQL.html, 
> v2-0001-CASSANDRA-1705.-doc-update-for-proposed-UPDATE.txt, 
> v2-0002-conforming-single-statement-UPDATE-impl.txt, 
> v2-0003-batched-UPDATEs.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> CQL specification and implementation for data manipulation.
> This corresponds to the following RPC methods:
> * insert()
> * batch_mutate() (writes, not deletes)
> The initial check-in to trunk/ uses a syntax that looks like:
> {code:SQL}
> UPDATE <CF> [USING CONSISTENCY.<LVL>] WITH ROW(<key>, COLUMN(<name>, 
> <value>)[, COLUMN(...)])[ AND ROW(...)];
> {code}
> Where:
> * <CF> is the column family name.
> * Rows are a parenthesized expressions with comma separated arguments for a 
> key and one or more columns.
> * Columns are a parenthesized expressions with comma separated arguments for 
> the name and value (timestamp is inaccessible).
> What is still undone:
> * Complete test coverage
> And of course, all of this is still very much open to further discussion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to