[
https://issues.apache.org/jira/browse/CASSANDRA-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886539#action_12886539
]
Jonathan Ellis commented on CASSANDRA-981:
------------------------------------------
+1 after minor clean up:
+ if (conf.dynamic_snitch == false)
+ return snitch;
+ else
+ return (IEndpointSnitch) new DynamicEndpointSnitch(snitch);
prefer !conf.dynamic_snitch (and prefer positive conditions first, to avoid
"!..else")
the cast should be unnecessary
personally I would go for a ?: here but if/else is ok
+ public void add(double i)
+ {
+ latencies.offer(i);
+ }
indent is wrong there
+ double exponent = (-1)*(t)/mean;
space b/t arithmetic operators here and everywhere else please
DynamicEndpointSnitchTest: several { need to be on new lines
> Dynamic endpoint snitch
> -----------------------
>
> Key: CASSANDRA-981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-981
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Brandon Williams
> Fix For: 0.7
>
> Attachments: 981.txt
>
>
> An endpoint snitch that automatically and dynamically infers "distance" to
> other machines without having to explicitly configure rack and datacenter
> positions solves two problems:
> The killer feature here is adapting to things like compaction or a
> failing-but-not-yet-dead disk. This is important, since when we are doing
> reads we pick the "closest" replica for actually reading data from (and only
> read md5s from other replicas). This means that if the closest replica by
> network topology is temporarily slow due to compaction (for instance), we'll
> have to block for its reply even if we get the other replies much much faster.
> Not having to manually re-sync your configuration with your network topology
> when changes (adding machines) are made is a nice bonus.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
