[
https://issues.apache.org/jira/browse/CASSANDRA-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871286#action_12871286
]
Gary Dusbabek commented on CASSANDRA-1127:
------------------------------------------
I'd like to give Stu a chance to explain his motivation for CASSANDRA-1117
before giving a +1 here.
But since I did a review, I wonder if now would be a good time to do a little
more sstable cleanup? Here are some things I came across:
* IndexSummary should be package protected. If SSTR weren't already so long it
could probably be made a private subclass there.
* SSTR.loadBloomFilter, loadIndexFile and mmap should be private methods.
* the methods that return SSTableScanners should probably be put into a factory
method(s) in SSTableScanner.
* the multitude of factory methods, and private and package constructors in
SSTR make hard to understand. I think there is room for consolidation.
> merge RowIndexed* back into SSTable*
> ------------------------------------
>
> Key: CASSANDRA-1127
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1127
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Affects Versions: 0.6
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 1127.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
